Re: [PATCH] hwmon: LM95245 driver

From: Alexander Stein
Date: Thu Jun 23 2011 - 06:50:43 EST


On Thursday 23 June 2011 11:33:16 Jean Delvare wrote:
> On Thu, 23 Jun 2011 11:14:52 +0200, Alexander Stein wrote:
> > Well, I noticed that. But I went the way lm95241 does. I'm also unsure
> > which interval to choose, if user specify a unsupported interval. Choose
> > the next small or the next greater one? Maybe you can give me a hint
> > here.
>
> BTW, is the LM95245 so incompatible that support couldn't be added to
> the lm95241 driver? If both devices are compatible to a reasonable
> degree, a single driver would be preferred.

Well, the register mapping is completly different. Also some configuration
bits are merged and moved into other registers than in lm95241. I doubt there
is much more compatibility than i2c transfers and temperature format (despite
unsigned/unsigned).

Regards,
Alexander
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/