Re: [PATCH 1/8] make do_notify_parent() return bool

[Tejun Heo]

Hello,

On Wed, Jun 22, 2011 at 11:08:18PM +0200, Oleg Nesterov wrote:
> - change do_notify_parent() to return a boolean, true if the task should
>   be reaped because its parent ignores SIGCHLD.
> 
> - update the only caller which checks the returned value, exit_notify().
> 
> This temporary uglifies exit_notify() even more, will be cleanuped by
> the next change.
> 
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
> ---
> @@ -2161,7 +2161,7 @@ extern int kill_pid_info_as_uid(int, str
>  extern int kill_pgrp(struct pid *pid, int sig, int priv);
>  extern int kill_pid(struct pid *pid, int sig, int priv);
>  extern int kill_proc_info(int, struct siginfo *, pid_t);
> -extern int do_notify_parent(struct task_struct *, int);
> +extern bool do_notify_parent(struct task_struct *, int);
>  extern void __wake_up_parent(struct task_struct *p, struct task_struct *parent);
>  extern void force_sig(int, struct task_struct *);
>  extern int send_sig(int, struct task_struct *, int);

While at it, would you mind adding the name of the parameters to the
prototype?  I find prototypes w/o parameter names a bit irksome.

Other than that,

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/