RE: [PATCH 1/3] mfd: Add S5M8751 register definitions

[Sangbeom Kim]

Hi Mark,

On Wed, Jun 22, 2011 at 09:42PM +0900, Mark Brown wrote:
> These don't look like register definitions:

OK, I will move it,
> 
> I posted a series earlier this week which adds a generic API for
> handling register maps on I2C/SPI devices - I'll post another version of
> it shortly, it'd be nice if you could loook to see if this is usable for
> you.
> 
Thanks for your comments.
After check the your patch, I will remake S5M8751 patch.

> > +/* S5M8751 internal interrupts */
> > +int s5m8751_register_irq(struct s5m8751 *s5m8751, int irq,
> > +			void (*handler) (struct s5m8751 *, int, void *),
> > +			void *data);
> > +
> > +int s5m8751_free_irq(struct s5m8751 *s5m8751, int irq);
> > +int s5m8751_mask_irq(struct s5m8751 *s5m8751, int irq);
> > +int s5m8751_unmask_irq(struct s5m8751 *s5m8751, int irq);
> > +int s5m8751_clear_irq(struct s5m8751 *s5m8751);
> 
> You should use genirq for this, it's supported this for quite some time
> now.  There's quite a few MFDs doing this which you can used for
> examples.
OK I will check it.


> > +/* S5M8751 sysfs functions */
> > +int s5m8751_uvlo_get(struct s5m8751 *s5m8751);
> > +int s5m8751_uvlo_set(struct s5m8751 *s5m8751, int voltage);
> > +
> > +int s5m8751_audio_dev_register(struct s5m8751 *s5m8751,
> > +						const char *name,
> > +						struct platform_device
**pdev);
> 
> These shouldn't need to be in the header.
OK, I will modify it.

Thanks and regards,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/