Re: [PATCH 7/10 v2] Generic Watchdog Timer Driver

[Wim Van Sebroeck]

Hi Arnd,

> On Saturday 18 June 2011 19:25:37 Wim Van Sebroeck wrote:
> > diff -urN linux-2.6.38-generic-part6/Documentation/watchdog/src/watchdog-with-timer-example.c linux-2.6.38-generic-part7/Documentation/watchdog/src/watchdog-with-timer-example.c
> > --- linux-2.6.38-generic-part6/Documentation/watchdog/src/watchdog-with-timer-example.c 2011-06-16 21:04:06.283940741 +0200
> > +++ linux-2.6.38-generic-part7/Documentation/watchdog/src/watchdog-with-timer-example.c 2011-06-17 09:52:32.866632635 +0200
> > @@ -45,6 +45,11 @@
> >  MODULE_PARM_DESC(timeout, "Watchdog timeout in seconds. "
> >         "(default = " __MODULE_STRING(WDT_TIMEOUT) ")");
> >  
> > +static int nowayout = WATCHDOG_NOWAYOUT;
> > +module_param(nowayout, int, 0);
> > +MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started. "
> > +       "(default = " __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
> > +
> >  static struct watchdog_device wdt_dev;
> >  static void wdt_timer_tick(unsigned long data);
> >  static DEFINE_TIMER(timer, wdt_timer_tick, 0, 0);
> > @@ -152,6 +157,8 @@
> >  
> >         /* Set watchdog_device parameters */
> >         wdt_dev.timeout = timeout;
> > +       if (nowayout)
> > +               set_bit(WDOG_NO_WAY_OUT, &wdt_dev.status);
> >  
> >         /* Register the watchdog timer device */
> >         res = watchdog_register_device(&wdt_dev);
> 
> Why is this a feature of the individual drivers and not of the core?

Some drivers/devices will need it (like Alan allready explained), where
others don't.

> Maybe it can be in both, so existing drivers don't need to change the user
> interface, but new drivers don't have to provide the option individually
> when you can simply set it for the base module.

the CONFIG_WATCHDOG_NOWAYOUT option in Kconfig allready stores the default
behaviour for all your drivers. the module param is initialized with it
during compilation ans allows to have it changed when you load the module.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/