Re: [PATCH x86 kvm] Fix register corruption in pvclock_scale_delta

From: Ian Campbell
Date: Wed Jun 22 2011 - 05:52:09 EST


On Wed, 2011-06-22 at 10:40 +0100, Avi Kivity wrote:
> On 06/22/2011 12:35 PM, Ian Campbell wrote:
> > On Sun, 2011-06-19 at 15:44 +0300, Avi Kivity wrote:
> > > On 06/16/2011 06:50 AM, Zachary Amsden wrote:
> > > > The 128-bit multiply in pvclock.h was missing an output constraint for
> > > > EDX which caused a register corruption to appear.
> >
> > Was there any particular symptom associated with corruption at that
> > particular point or just general badness?
> >
>
> Time went backwards and forwards as vcpus were migrated across cpus.

Oops!

> The problem was in the host, not the guest, so Xen should not be affected.

Good to know, thanks!

Ian.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/