Re: [patch 10/16] sched: throttle entities exceeding their allowedbandwidth

[Hidetoshi Seto]

(2011/06/21 16:16), Paul Turner wrote:
> Add conditional checks time of put_prev_entity() and enqueue_entity() to detect
> when an active entity has exceeded its allowed bandwidth and requires
> throttling.
> 
> Signed-off-by: Paul Turner <pjt@xxxxxxxxxx>
> 
> ---
(snip)
> @@ -1403,7 +1412,7 @@ static void account_cfs_rq_runtime(struc
>  	 * if we're unable to extend our runtime we resched so that the active
>  	 * hierarchy can be throttled
>  	 */
> -	if (!assign_cfs_rq_runtime(cfs_rq))
> +	if (!assign_cfs_rq_runtime(cfs_rq) && likely(cfs_rq->curr))
>  		resched_task(rq_of(cfs_rq)->curr);
>  }
>  

Nit: I think this hunk could be included in patch 08/16.

The rest is good.

Reviewed-by: Hidetoshi Seto <seto.hidetoshi@xxxxxxxxxxxxxx>


Thanks,
H.Seto

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/