Re: [PATCH v7 02/11] omap_hsmmc: add support for pre_req and post_req

From: Per Forlin
Date: Wed Jun 22 2011 - 05:31:23 EST


On 22 June 2011 10:51, Nickolay Nickolaev <nicknickolaev@xxxxxxxxx> wrote:
> Hello,
>
> this one's causing me compilation trouble troubles when CONFIG_DMA_ENGINE is
> not defined.
>
I don't see this issue when I compile the kernel for a Pandaboard
without CONFIG_DMA_ENGINE being set. Could you please clarify or show
me your build log?
I don't see how host->next_data.cookie is connected to DMA_ENGINE.

> On Wed, Jun 22, 2011 at 2:38 AM, Per Forlin <per.forlin@xxxxxxxxxx> wrote:
>>
>> @@ -2077,6 +2155,7 @@ static int __init omap_hsmmc_probe(struct
>> platform_device *pdev)
>>        host->mapbase   = res->start;
>>        host->base      = ioremap(host->mapbase, SZ_4K);
>>        host->power_mode = MMC_POWER_OFF;
>> +       host->next_data.cookie = 1;
>>
>>        platform_set_drvdata(pdev, host);
>>        INIT_WORK(&host->mmc_carddetect_work, omap_hsmmc_detect);
>> --
>> 1.7.4.1
>>
>>
>
> Maybe we can wrap it in a function as the others.
>
> regards,
> Nikolay Nikolaev
>

Regards,
Per
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/