Re: module: sysfs - add 'uevent' file to allow coldplug

[Rusty Russell]

On Wed, 22 Jun 2011 00:47:55 +0200, Kay Sievers <kay.sievers@xxxxxxxx> wrote:
> On Tue, Jun 21, 2011 at 03:53, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
> > Sorry, that's another vague answer :(
> >
> > udev already knows about module load
> 
> Not for built-ins.

OK, I re-read your commit message, and down the bottom it does say what
it *does*:

>        This adds the currently missing /sys/module/<name>/uevent files
>        to all module entries.

I apologize for skimming, but this should be the *title* of the patch!

Then I saw your patch hit params.c and thought you were adding a uevent
file to /sys/module/<name>/parameters/.  I was even more confused when
you replied:

> Hook system management into module-load events, which might include
> changing module parameters in /sys/module/*/parameters/*...

Because loading a module might *create* module parameters, but it won't
*change* them.  If we want to have events for change, we need much
more...

Now we've got that sorted, is there a reason why you changed all the
signatures rather than just using mod->mkobj in store_uevent()?

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/