Re: [PATCH 1/2 V2] ksm: take dirty bit as reference to avoidvolatile pages scanning

From: Chris Wright
Date: Tue Jun 21 2011 - 20:46:33 EST


* Nai Xia (nai.xia@xxxxxxxxx) wrote:
> On Wednesday 22 June 2011 05:42:33 you wrote:
> > * Nai Xia (nai.xia@xxxxxxxxx) wrote:
> > > This patch makes the page_check_address() can validate if a subpage is
> > > in its place in a huge page pointed by the address. This can be useful when
> > > ksm does not split huge pages when looking up the subpages one by one.
> >
> > Just a quick heads up...this patch does not compile by itself. Could you
> > do a little patch cleanup? Start with just making sure the Subject: is
> > correct for each patch. Then make sure the 3 are part of same series.
> > And finally, make sure each is stand alone and complilable on its own.
>
> Oh, indeed, there is a kvm & mmu_notifier related patch not named in a series.
> But with a same email thread ID, I think

Right, in same thread, but it ends up with:

[PATCH 1/2] ksm: take dirty bit as reference to avoid volatile pages...
[PATCH] mmu_notifier, kvm: Introduce dirty bit...
[PATCH 2/2] ksm: take dirty bit as reference to avoid volatile pages...

Not a big deal, but also easy to fix up ;)

> .... I had thought it's ok...
> I'll reformat this patch set to fullfill these requirements.

thanks,
-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/