Re: [PATCH 1/3] mm: completely disable THP by transparent_hugepage=never

[Rik van Riel]

On 06/21/2011 12:08 AM, Cong Wang wrote:

> The thing is that we can save ~10K by adding 3 lines of code as this
> patch showed, where else in kernel can you save 10K by 3 lines of code?
> (except some kfree() cases, of course) So, again, why not have it? ;)

Because we'll end up with hundreds of lines of code, just
to save under 1MB of memory.  Which ends up not being saved
at all, because people will still give their kdump kernel
128MB :)

The only really big gain you are likely to get is making
sure all the per-cpu memory is not allocated in the kdump
kernel (which is booted with 1 cpu).

That is a big, multi-MB, optimization that can be implemented
in one place.  Large savings for a localized change, so you
actually have a chance of having the changes accepted upstream.

--
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/