Re: [PATCH 4/4] mm: introduce no_ksm to disable totally KSM

From: Andrea Arcangeli
Date: Tue Jun 21 2011 - 09:33:39 EST


On Tue, Jun 21, 2011 at 04:10:45PM +0800, Amerigo Wang wrote:
> Introduce a new kernel parameter "no_ksm" to totally disable KSM.

Here as well this is the wrong approach. If you want to save memory,
you should make ksmd quit when run=0 and start only when setting
ksm/run=1. And move the daemon hashes and slabs initializations to the
ksmd daemon start. Not registering in sysfs and crippling down the
feature despite you loaded the proper .text into memory isn't good.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/