Re: [PATCH 1/5] VFS: Do (nearly) lockless generic_file_llseek

[Andi Kleen]

On Fri, Jun 17, 2011 at 02:40:14PM +0200, Arnd Bergmann wrote:
> On Thursday 16 June 2011 23:07:18 Andi Kleen wrote:
> > So still need a lock, but can use a cheap local one.
> > 
> > This patch implements this new scheme in generic_file_llseek.
> > I dropped generic_file_llseek_unlocked and changed all callers.
> 
> What about default_llseek? If you change generic_file_llseek, you should
> probably change that, too.

That's used by a lot of drivers, and since I cannot audit them
all I chose to be conservative. not sure it's ever performance
critical anyways?

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/