RE: [PATCH 1/5] staging: hv: fix some white spaces in netvsc driver

From: Haiyang Zhang
Date: Fri Jun 17 2011 - 12:48:39 EST


> -----Original Message-----
> From: Nicolas Kaiser [mailto:nikai@xxxxxxxxx]
> Sent: Friday, June 17, 2011 12:03 PM
> To: Haiyang Zhang
> Cc: Hank Janssen; KY Srinivasan; Abhishek Kane (Mindtree Consulting
> PVT LTD); gregkh@xxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> devel@xxxxxxxxxxxxxxxxxxxxxx; virtualization@xxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/5] staging: hv: fix some white spaces in netvsc
> driver
>
> * Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>:
> > diff --git a/drivers/staging/hv/netvsc.c
> b/drivers/staging/hv/netvsc.c
> > index 0ae35e7..b6e1fb9 100644
> > --- a/drivers/staging/hv/netvsc.c
> > +++ b/drivers/staging/hv/netvsc.c
> > @@ -525,10 +525,10 @@ int netvsc_send(struct hv_device *device,
> > (unsigned long)packet);
> > } else {
> > ret = vmbus_sendpacket(device->channel, &sendMessage,
> > - sizeof(struct nvsp_message),
> > - (unsigned long)packet,
> > - VM_PKT_DATA_INBAND,
> > -
> VMBUS_DATA_PACKET_FLAG_COMPLETION_REQUESTED);
> > + sizeof(struct nvsp_message),
> > + (unsigned long)packet,
> > + VM_PKT_DATA_INBAND,
> > + VMBUS_DATA_PACKET_FLAG_COMPLETION_REQUESTED);
>
> Why? The arguments were nicely aligned.

Because the last line went beyond 80 chars, and triggered checkpatch warning.

Thanks,
-Haiyang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/