Re: [PATCH net-next V2] drivers/net: Remove casts of void *

From: David Dillow
Date: Fri Jun 17 2011 - 11:15:32 EST


On Thu, 2011-06-16 at 22:08 -0700, Joe Perches wrote:
> Unnecessary casts of void * clutter the code.
>
> These are the remainder casts after several specific
> patches to remove netdev_priv and dev_priv.

> diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c
> index 3de4283..1d5091a 100644
> --- a/drivers/net/typhoon.c
> +++ b/drivers/net/typhoon.c
> @@ -2367,7 +2367,7 @@ typhoon_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>
> dev->irq = pdev->irq;
> tp = netdev_priv(dev);
> - tp->shared = (struct typhoon_shared *) shared;
> + tp->shared = shared;
> tp->shared_dma = shared_dma;
> tp->pdev = pdev;
> tp->tx_pdev = pdev;

Acked-by: David Dillow <dave@xxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/