Re: Re: [alsa-devel] [PATCH v5 15/18] ASoC: twl6040: Remove pll and headset mode dependency

[Péter Ujfalusi]

On Friday 17 June 2011 15:27:59 Mark Brown wrote:
> On Mon, Jun 13, 2011 at 07:37:47PM +0300, Peter Ujfalusi wrote:
> > From: Misael Lopez Cruz <misael.lopez@xxxxxx>
> > 
> > Remove dependency between pll (hppll, lppll) and headset power
> > mode (low-power, high-performance), as headset power mode can
> > be used with any pll.
> 
> Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> 
> but...
> 
> > A new control is created to allow headset power mode configuration
> > from userspace. Changing headset power mode during earpiece related
> > usecases is not allowed as earpiece requires HS DAC in HP mode.
> 
> Might be nicer to allow the user to set the control given that you'll
> just ignore the configured value anyway if it's not usable right now.

Yeah, we can allow the change, but skip the register updates for use cases 
when it is not allowed.

I did spot other issue related to this power mode handling: the DAPM event 
handler has been attached to HFDAC, and not to the HSDAC, so the refcounting 
is done for a wrong set of DAC... The HFDACs has no relationship with the 
Earpiece output (it is connected to HSDACL).

-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/