Re: [PATCH] FRV: Hook up gpiolib support

[Felipe Balbi]

On Fri, Jun 17, 2011 at 11:50:59AM +0100, David Howells wrote:
> Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> 
> > And to repeat what I said: the generic header prototypes everything it
> > needs before it uses it so there should be no problem here, it's not
> > been a problem on the other architectures using this code verbatim.
> > Please be more specific.
> 
> Okay:
> 
>   CC      drivers/mtd/maps/gpio-addr-flash.o
> In file included from /data/frv/linux-2.6-frv/arch/frv/include/asm/gpio.h:21,
>                  from include/linux/gpio.h:8,
>                  from drivers/mtd/maps/gpio-addr-flash.c:17:
> include/asm-generic/gpio.h: In function 'gpio_get_value_cansleep':
> include/asm-generic/gpio.h:233: error: implicit declaration of function 'gpio_get_value'
> include/asm-generic/gpio.h: In function 'gpio_set_value_cansleep':
> include/asm-generic/gpio.h:239: error: implicit declaration of function 'gpio_set_value'
> drivers/mtd/maps/gpio-addr-flash.c: In function 'gpio_flash_probe':
> drivers/mtd/maps/gpio-addr-flash.c:234: error: implicit declaration of function 'gpio_request'
> drivers/mtd/maps/gpio-addr-flash.c:238: error: implicit declaration of function 'gpio_free'
> drivers/mtd/maps/gpio-addr-flash.c:242: error: implicit declaration of function 'gpio_direction_output'
> 
> 
> Let me expand on my explanation earlier:
> 
>  (1) asm-generic/gpio.h has an _inline_ function:
> 
> 	static inline int gpio_get_value_cansleep(unsigned gpio)
> 	{
> 		might_sleep();
> 		return gpio_get_value(gpio);
> 	}
> 
>  (2) gpio_get_value() is implemented in asm/gpio.h.  It is not declared in
>      asm-generic/gpio.h.
> 
>  (3) Therefore, the #inclusion of asm-generic/gpio.h must come _after_ the
>      implementation of gpio_get_value() in asm/gpio.h.
> 
>  (4) asm/gpio.h implements the aforementioned inline function:
> 
> 	static inline int gpio_get_value(unsigned int gpio)
> 	{
> 		return __gpio_get_value(gpio);
> 	}
> 
>  (5) __gpio_get_value() is declared in asm-generic/gpio.h.  It is not declared
>      in asm/gpio.h.
> 
>  (6) Therefore, the #inclusion of asm/gpio.h must come _before_ the
>      implementation of gpio_get_value() in asm/gpio.h.
> 
> Thus (3) and (6) contradict.

sounds like it's time to move all that mess to one header alone ?!?
<linux/gpio.h> should be self-sufficient ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature