Re: [ANNOUNCE] Native Linux KVM tool v2

[Pekka Enberg]

Hi Christoph,

On Thu, Jun 16, 2011 at 09:21:03AM +0300, Pekka Enberg wrote:
>> And btw, we use sync_file_range()

On Thu, Jun 16, 2011 at 12:24 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> Which doesn't help you at all.  sync_file_range is just a hint for VM
> writeback, but never commits filesystem metadata nor the physical
> disk's write cache.  In short it's a completely dangerous interface, and
> that is pretty well documented in the man page.

Doh - I didn't read it carefully enough and got hung up with:

    Therefore, unless the application is strictly performing overwrites of
    already-instantiated disk blocks, there are no guarantees that the data will
    be available after a crash.

without noticing that it obviously doesn't work with filesystems like
btrfs that do copy-on-write.

What's the right thing to do here? Is fdatasync() sufficient?

                        Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/