Re: [PATCH] dma/ep93xx_dma.c: local symbols should be static

[Koul, Vinod]

On Fri, 2011-06-10 at 15:15 -0700, H Hartley Sweeten wrote:
> The symbol 'ep93xx_dma_prep_dma_memcpy' is only used in this driver
> and should be marked static.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
> Cc: Mika Westerberg <mika.westerberg@xxxxxx>
> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
> Cc: Vinod Koul <vinod.koul@xxxxxxxxx>

Applied Thanks
> 
> ---
> 
> diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
> index 0766c1e..5d7a49b 100644
> --- a/drivers/dma/ep93xx_dma.c
> +++ b/drivers/dma/ep93xx_dma.c
> @@ -902,7 +902,7 @@ static void ep93xx_dma_free_chan_resources(struct dma_chan *chan)
>   *
>   * Returns a valid DMA descriptor or %NULL in case of failure.
>   */
> -struct dma_async_tx_descriptor *
> +static struct dma_async_tx_descriptor *
>  ep93xx_dma_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest,
>  			   dma_addr_t src, size_t len, unsigned long flags)
>  {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/