Re: [PATCH 6/8 v2] x86, UV: remove cpumask_t from the stack

From: Pekka Enberg
Date: Wed Jun 15 2011 - 12:35:19 EST


On Wed, Jun 15, 2011 at 6:47 PM, Cliff Wickman <cpw@xxxxxxx> wrote:
> From: Cliff Wickman <cpw@xxxxxxx>
>
> Remove the stack-resident cpumask_t from reset_with_ipi() by allocating
> one per uvhub.
>
> Due to the limited size of the stack the potentially huge cpumask_t may
> cause stack overrun.  We haven't seen it happen yet, but we need to make it
> a practice not to push such structures onto the stack.
>
> Diffed against 3.0.0-rc3
>
> Signed-off-by: Cliff Wickman <cpw@xxxxxxx>

Reviewed-by: Pekka Enberg <penberg@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/