Re: [PATCH] s3c2410_udc: udc command always disables pull-up insteadof passing the command

[Skacore Systems]

I don't care much about pushing this into mainline. It's a bug and
it's up to kernel developers to fix that.
I was aware that kernel devs are bunch of lazy dicks and I'm not going
to do more work for one line patch.

Howg.

On Tue, Jun 14, 2011 at 6:49 PM, Felipe Balbi <balbi@xxxxxx> wrote:
> Hi,
>
> On Tue, Jun 14, 2011 at 04:58:40PM +0200, Skacore Systems wrote:
>> Sorry for the HTML,
>> There is a bug in s3c2410_udc driver, which triggers when using custom
>> UDC command for USB pull-up.
>> As a result driver is always calling user defined UDC command with
>> wrong parameter (S3C2410_UDC_P_DISABLE) instead of
>> just passing the parameter to the user defined function.
>
> please take a look at Documentation/SubmittingPatches and fix up your
> patch so that it can be applied. Also, when sending patches,
> scripts/get_maintainer.pl will give you a hint of who you should put on
> Cc ;-)
>
> --
> balbi
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/