Re: [PATCH] x86, vsyscall: Fix build warning in vsyscall_64.c

[Andrew Lutomirski]

On Tue, Jun 14, 2011 at 5:31 PM, Ingo Molnar <mingo@xxxxxxx> wrote:
>
> * Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
>> On Tue, Jun 14, 2011 at 2:16 PM, Ingo Molnar <mingo@xxxxxxx> wrote:
>> >
>> > I think correctness trumps code size and turning BUG() and BUG_ON()
>> > into a NOP is just crazy ...
>>
>> Umm. It's even CRAZIER to turn it into a "compiler generates random code".
>
> Sigh, i assumed it got turned into an infinite loop - that is what
> i've done in a prior patch.
>
> You are right, unreachable() is bogus and you'd also be right to
> suggest that i should not comment on patches after 11pm ;-)

What we want is a magic GCC trick that says "don't warn about code
paths that go through here but generate the same code as you would
without this annotation."  I don't think such a thing exists.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/