Re: [PATCH] FRV: Hook up gpiolib support

[David Howells]

Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

> Allow people to use gpiolib on FRV, mostly for build coverage as it
> seems more useful to standardise the API than handle making it optional.
> 
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

Nack.

There's an ordering problem.  The #inclusion of asm-generic/gpio.h must come
both before *and* after the functions in asm/gpio.h.  Take gpio_get_value()
for instance, it requires __gpio_get_value() - which is defined by the generic
header - but is used by gpio_get_value_cansleep() in the generic header.

You must split asm-generic/gpio.h.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/