Re: [PATCH v4 3.0-rc2-tip 2/22] 2: uprobes: Breakground pagereplacement.

From: Oleg Nesterov
Date: Tue Jun 14 2011 - 10:30:14 EST


On 06/14, Peter Zijlstra wrote:
>
> On Mon, 2011-06-13 at 19:00 +0200, Oleg Nesterov wrote:
> >
> > Also. This is called under down_read(mmap_sem), can't we race with
> > access_process_vm() modifying the same memory?
>
> Shouldn't matter COW and similar things are serialized using the pte
> lock.

Yes, but afaics this doesn't matter. Suppose that write_opcode() is
called when access_process_vm() does copy_to_user_page(). We can cow
the page before memcpy() completes.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/