Re: [PATCH net-next 2/2] drivers/net: Remove casts of void *

[Geert Uytterhoeven]

Hi Joe,

On Tue, Jun 14, 2011 at 16:00, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Tue, 2011-06-14 at 11:21 +0200, Geert Uytterhoeven wrote:
>> On Tue, Jun 14, 2011 at 06:02, Joe Perches <joe@xxxxxxxxxxx> wrote:
>> > Unnecessary casts of void * clutter the code.
>> > --- a/drivers/net/a2065.c
>> > +++ b/drivers/net/a2065.c
>> > @@ -426,7 +426,7 @@ static irqreturn_t lance_interrupt (int irq, void *dev_id)
>> > Â Â Â Âvolatile struct lance_regs *ll;
>> > Â Â Â Âint csr0;
>> >
>> > - Â Â Â dev = (struct net_device *) dev_id;
>> > + Â Â Â dev = dev_id;
>>
>> I think it would look better if you merge this line with the line that
>> defines "dev".
>
> I think so too, but I also think it should look like below
> and that's something better done in a separate pass, don't
> you think?
>
> diff --git a/drivers/net/a2065.c b/drivers/net/a2065.c
> index deaa8bc..25ea98a 100644
> --- a/drivers/net/a2065.c
> +++ b/drivers/net/a2065.c
> @@ -421,16 +421,11 @@ static int lance_tx (struct net_device *dev)
>
> Âstatic irqreturn_t lance_interrupt (int irq, void *dev_id)
> Â{
> - Â Â Â struct net_device *dev;
> - Â Â Â struct lance_private *lp;
> - Â Â Â volatile struct lance_regs *ll;
> + Â Â Â struct net_device *dev = dev_id;
> + Â Â Â struct lance_private *lp = netdev_priv(dev);
> + Â Â Â volatile struct lance_regs *ll = lp->ll;
> Â Â Â Âint csr0;
>
> - Â Â Â dev = (struct net_device *) dev_id;
> -
> - Â Â Â lp = netdev_priv(dev);
> - Â Â Â ll = lp->ll;
> -
> Â Â Â Âll->rap = LE_CSR0; Â Â Â Â Â Â Â/* LANCE Controller Status */
> Â Â Â Âcsr0 = ll->rdp;

Definitely better!

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/