Re: [RFC PATCHv5 2/7] HSI: omap_ssi: Introducing OMAP SSI driver

[Carlos Chinea]

Hi,
-- cut--
> > +
> > +static int __init ssi_init(void)
> > +{
> > +	return platform_device_register(&ssi_pdev);
> > +}
> > +subsys_initcall(ssi_init);
> 
> Looks like you need something here also to prevent this subsys_initcall
> on running on all boards. Maybe have a pointer to ssi_pdev that only
> gets initialized after omap_ssi_config?
> 
> Then you can have ssi_init fail if no configuration is called:
> 
> 	if (!pdev)
> 		return -ENODEV;
> 
> 	return platform_device_register(pdev);
> 

Right. I'll do those changes.

Thanks,
Carlos

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/