Re: [PATCH 11/12] tmpfs: use kmemdup for short symlinks

From: Pekka Enberg
Date: Tue Jun 14 2011 - 07:16:19 EST


On Tue, Jun 14, 2011 at 1:57 PM, Hugh Dickins <hughd@xxxxxxxxxx> wrote:
> But we've not yet removed the old swp_entry_t i_direct[16] from
> shmem_inode_info.  That's because it was still being shared with the
> inline symlink.  Remove it now (saving 64 or 128 bytes from shmem inode
> size), and use kmemdup() for short symlinks, say, those up to 128 bytes.
>
> I wonder why mpol_free_shared_policy() is done in shmem_destroy_inode()
> rather than shmem_evict_inode(), where we usually do such freeing?  I
> guess it doesn't matter, and I'm not into NUMA mpol testing right now.
>
> Signed-off-by: Hugh Dickins <hughd@xxxxxxxxxx>

Reviewed-by: Pekka Enberg <penberg@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/