Re: [PATCH net-next 2/2] drivers/net: Remove casts of void *

[Geert Uytterhoeven]

On Tue, Jun 14, 2011 at 06:02, Joe Perches <joe@xxxxxxxxxxx> wrote:
> Unnecessary casts of void * clutter the code.

> --- a/drivers/net/a2065.c
> +++ b/drivers/net/a2065.c
> @@ -426,7 +426,7 @@ static irqreturn_t lance_interrupt (int irq, void *dev_id)
> Â Â Â Âvolatile struct lance_regs *ll;
> Â Â Â Âint csr0;
>
> - Â Â Â dev = (struct net_device *) dev_id;
> + Â Â Â dev = dev_id;

I think it would look better if you merge this line with the line that
defines "dev".

>
> Â Â Â Âlp = netdev_priv(dev);
> Â Â Â Âll = lp->ll;

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/