Re: [PATCH 1/3] md/raid5: fix raid5_set_bi_hw_segments

From: NeilBrown
Date: Tue Jun 14 2011 - 00:13:02 EST


On Mon, 13 Jun 2011 23:48:22 +0900 Namhyung Kim <namhyung@xxxxxxxxx> wrote:

> The @bio->bi_phys_segments consists of active stripes count in the
> lower 16 bits and processed stripes count in the upper 16 bits. So
> logical-OR operator should be bitwise one.
>
> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxx>
> ---
> drivers/md/raid5.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index 346e69bfdab3..fa6ac70dc72f 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -129,7 +129,7 @@ static inline int raid5_dec_bi_hw_segments(struct bio *bio)
>
> static inline void raid5_set_bi_hw_segments(struct bio *bio, unsigned int cnt)
> {
> - bio->bi_phys_segments = raid5_bi_phys_segments(bio) || (cnt << 16);
> + bio->bi_phys_segments = raid5_bi_phys_segments(bio) | (cnt << 16);
> }
>
> /* Find first data disk in a raid6 stripe */


Thanks for this and the other 2!!
I have added "Cc: stable@xxxxxxxxxx" to the first two and applied them. I
expect to send them off to Linus later today.

Thanks,
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/