Re: [PATCH 15/15] tracing/kprobes: Fix kprobe-tracer to support stacktrace

[Masami Hiramatsu]

(2011/06/13 21:14), Steven Rostedt wrote:
> On Mon, 2011-06-13 at 13:50 +0200, Ingo Molnar wrote:
>> * Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>>
>>>>> +	__ftrace_trace_stack(global_trace.buffer, flags, 3, preempt_count(),
>>>>> +			     NULL);
>>>>
>>>> pointless linebreak.
>>>
>>> Again, probably to do with the 80 char limit.
>>
>> Well, the point of the 80 char limit warning these days is to force a 
>> cleanup of the code. Breaking the line mindlessly *uglifies* the code 
>> so it's pointless to do it.
>>
>> In terms of terminal readability line length up to 90-100 cols is 
>> acceptable for code that is otherwise not ugly.
> 
> I totally agree. I've just had arguments with others that are more 80
> character nazi than I am. ;)

I see, nowadays most of laptops has a wide screen (16:9) :P


-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@xxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/