Re: [PATCH 0/3] bdi write bandwidth estimation

[Andrew Morton]

On Sun, 12 Jun 2011 23:18:21 +0800
Wu Fengguang <fengguang.wu@xxxxxxxxx> wrote:

> Do bdi write bandwidth estimation in the flusher thread at 200ms intervals,

stdrant: anything which is paced using "seconds" is basically always
wrong.  The bandwidth of storage systems varies by who-knows-how-many
orders of magnitude.  If 200ms is correct for one system then it is
vastly incorrect for another.

A more suitable clock for this estimate would be "per 200 requests",
for a block-based BDI.

Also of course the bandwidth of a particular BDI varies vastly
depending on workload.  For the purpose of this work, that's probably
a desirable thing.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/