Re: [PATCH v4 3.0-rc2-tip 4/22] 4: Uprobes: register/unregisterprobes.

[Steven Rostedt]

On Fri, 2011-06-10 at 01:03 +0200, Peter Zijlstra wrote:

> The comment in del_consumer() that says: 'drop creation ref' worries me
> and makes me thing that is the last reference around and the uprobe will
> be freed right there, which clearly cannot happen since its not yet
> removed from the RB-tree.

I agree about that comment. It scared me too, not only about the RB
tree, but the uprobe is used later in that function to drop the
write_rwsem.

I think that comment needs to be changed to something like:

/* Have caller drop the creation ref */

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/