Re: [PATCH V2 00/12] tpm + tpm_tis : Various fixes

From: Stefan Berger
Date: Mon Jun 13 2011 - 11:34:34 EST


On 05/31/2011 09:23 AM, Rajiv Andrade wrote:
Hi Stefan,

Yes, I'll have them reviewed again and in a git pull request real soon.
Has the review-oracle spoken in the meantime ? What did it say?

Stefan

Thanks, Rajiv Andrade
Security Development
IBM Linux Technology Center

On 05/27/2011 05:55 PM, Stefan Berger wrote:
Rajiv,

are you planning to use these patches?

Regards,
Stefan


On 03/30/2011 12:13 PM, Stefan Berger wrote:
This patchset fixes various issues in the general TPM driver and the TPM TIS
driver. Some of the patches were previously posted, and are being re-posted
without change, while other patches were refactored. This patchset applies to
the tip of the main git tree.

Patches 1-6 are related to using the timeouts that the TPM reports, along with
work-arounds for TPMs that don't report the timeouts in microseconds but
rather in milliseconds.

Patch 7 fixes the display of the public key of the TPM's Endorsement Key in
sysfs.

Patch 8 re-enables the TPM's interrupts after resume from S3.

Patch 9 is useful if the TPM is run in interrupt mode and delays the S3 suspend
until the TPM has finished processing a command.

Patch 10 fixes several aspects of the code around the probing for interrupts.

Patch 11 introduces automatic probing for the Intel iTPM flaw. The probing
is useful in combination with the 'force' module parameter that enables
the interrupt mode on some machines but then ends up circumventing ACPI to
determine whether an Intel iTPM is present to activate the work-around. So,
in that case we can rely on the probing.

Patch 12 fixes a typo.

I have tested these patches on four different types of machines. They worked
fine there even though the TPM could not be used in interrupt mode on all of
them (IRQ line not connected?).

V2:
- following Rajiv's feedback. Splitting the durations and timeout
patches in 3 parts.
- slightly rearranging the order of the patches

Regards,
Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/