Re: [PATCH] usb:gadget: use min_t() macro instead of min()

From: Felipe Balbi
Date: Mon Jun 13 2011 - 07:57:38 EST


Hi,

On Mon, Jun 13, 2011 at 02:52:34PM +0300, Tanya Brokhman wrote:
> > On Sun, Jun 12, 2011 at 02:14:46PM +0300, Tatyana Brokhman wrote:
> > > Signed-off-by: Tatyana Brokhman <tlinder@xxxxxxxxxxxxxx>
> >
> > I need a sensible commit log for this. Why do we need to change all
> > min() to min_t() ?
> >
>
> Actually, Alan asked me to make this change in one place in dummy_hcd. I
> wasn't aware of the min_t macro before that. So when I searched the code for
> other places I found quite a few and just thought that it would be "nicer"
> to use min_t() instead of min() with casting.
> So we don't "need" to make this change. Everything works as is. This patch
> only makes the code look nicer, nothing more.
> I can elaborate the above in the commit log if you want.

Yes, that's what I need. The question was supposed to be answered by the
commit log ;-)

--
balbi

Attachment: signature.asc
Description: Digital signature