Re: [PATCH 13/15] x86: Swap save_stack_trace_regs parameters

[Steven Rostedt]

On Mon, 2011-06-13 at 12:18 +0200, Ingo Molnar wrote:
> * Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> 
> > Cc: Ingo Molnar <mingo@xxxxxxx>
> > Cc: yrl.pp-manager.tt@xxxxxxxxxxx
> > Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>
> > Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> > Cc: Namhyung Kim <namhyung@xxxxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> 
> That looks very messy:
> 
>  - there's duplicates
>  - the SOB is in the middle
>  - when there's a Link entry there's no need for a Cc: linux-kernel entry

Hmm, that was caused by my "do-git-am" script, that pulls in patches
from email. I added a new feature to add Cc's that were on the email but
not in the "Cc" list. I'll make sure it adds Cc's with other Cc's next
time.

BTW, I have it strip Cc's to me, do you want me to remove the Cc to you
as well? Or just keep the Cc to you in the change log (as I do now)?

As for the Cc to linux-kernel, I thought I fixed that. The script is
suppose to remove that Cc as well. I wonder why it missed it here? I
should have caught that on my final review. Sorry to miss it.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/