Re: [PATCH] efifb: Fix call to wrong unregister function

[Maarten Lankhorst]

Hi Andy,

2011/6/13 Andy Lutomirski <luto@xxxxxxx>:
> On 06/12/2011 06:52 AM, wanlong.gao wrote:
>>
>> <snip>
>>
>> Hi Maarten:
>> It registered efifb_device but try to unregistered efifb_driver,
>> so I think you should fix it like this?
>>
>> Signed-off-by: Wanlong Gao<wanlong.gao@xxxxxxxxx>
>> ---
>> Âdrivers/video/efifb.c | Â Â2 +-
>> Â1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c
>> index 69c49df..784139a 100644
>> --- a/drivers/video/efifb.c
>> +++ b/drivers/video/efifb.c
>> @@ -541,7 +541,7 @@ static int __init efifb_init(void)
>> Â Â Â Â */
>> Â Â Â Âret = platform_driver_probe(&efifb_driver, efifb_probe);
>> Â Â Â Âif (ret) {
>> - Â Â Â Â Â Â Â platform_device_unregister(&efifb_driver);
>> + Â Â Â Â Â Â Â platform_device_unregister(&efifb_device);
>> Â Â Â Â Â Â Â Âreturn ret;
>> Â Â Â Â}
>>
>
> Acked-by: Andy Lutomirski <luto@xxxxxxx>
>
> That's my bug. ÂSorry. ÂI'm not sure why it compiled, though.
It compiled, but threw a warning. :)

~Maarten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/