Re: [PATCH] sysctl: remove impossible condition check

From: Jesper Juhl
Date: Fri Jun 10 2011 - 04:04:44 EST


On Fri, 10 Jun 2011, Lucas De Marchi wrote:

> Remove checks for conditions that will never happen. If procname is NULL
> the loop would already had bailed out, so there's no need to check it
> again.
>
> At the same time this also compacts the function find_in_table() by
> refactoring it to be easier to read.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxxxxxxx>

Looks good to me.

Reviewed-by: Jesper Juhl <jj@xxxxxxxxxxxxx>

--
Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/