Re: [PATCH RESEND]Remove a warning for drivers/edac/i82975x_edac.c

[Harry Wei]

On Thu, Jun 09, 2011 at 10:37:47AM -0700, Randy Dunlap wrote:
> On Thu, 9 Jun 2011 11:04:13 +0800 Harry Wei wrote:
> 
> > -	page = (unsigned long) info->eap;
> > +	page = (unsigned long long) info->eap;
> 
> But page is still unsigned long, not unsigned long long...
Yup, but if we can define a 'unsigned long long' type?
> 
> >  	if (info->xeap & 1)
> > -		page |= 0x100000000ul;
> > +		page |= 0x100000000ull;
> 
> and just making this second change fixes the warning.
I will try my best. Can anyone give some other comments?
> 
> I don't know what the right answer is, but this patch does not look
> complete to me.
I will try to give a v2.
> 
> Back in April there was a discussion about this warning message and the
> conclusion was that this driver should be replaced.  See
> https://lkml.org/lkml/2011/4/21/232 and its replies.
> But we seem to be having problems reaching the EDAC subsystem maintainer
> (again cc-ed).
You have not got a exact conclusion about this warning.
Maybe Arvind knows more about this warning.(cc'ed)


Thanks
Harry Wei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/