Re: [PATCH] sched: remove resetting exec_start in put_prev_task_rt()

[Yong Zhang]

On Thu, Jun 9, 2011 at 8:34 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> I disagree. Yes the exec_start is reset there, but I like the fact that
> it's 0 when not running.

Actually this depends on how we look at the code:
if we set exec_start to 0 explicitly, as you said the code is more direct and
readable.
if we don't set exec_start to 0, we can save one instruction though
it's minor.

I have no strong opinion on either of them :)

BTW, put_prev_task_fair() doesn't set exec_start to 0.

Thanks,
Yong


-- 
Only stand for myself
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/