Re: [PATCH v4 3.0-rc2-tip 2/22] 2: uprobes: Breakground pagereplacement.

[Peter Zijlstra]

On Tue, 2011-06-07 at 18:28 +0530, Srikar Dronamraju wrote:
> +       ret = anon_vma_prepare(vma);
> +       if (ret)
> +               goto unlock_out;

You just leaked new_page.

> +
> +       lock_page(new_page);
> +       ret = __replace_page(vma, old_page, new_page);
> +       unlock_page(new_page);
> +       if (ret != 0)
> +               page_cache_release(new_page);
> +unlock_out:
> +       unlock_page(old_page);
> +
> +put_out:
> +       put_page(old_page); /* we did a get_page in the beginning */
> +       return ret;
> +} 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/