Re: [PATCH 2/3] perf_events: fix validation of events using anextra reg (v4)

[Peter Zijlstra]

On Thu, 2011-06-09 at 22:36 +0200, Stephane Eranian wrote:
> On Thu, Jun 9, 2011 at 8:40 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> > On Mon, 2011-06-06 at 16:57 +0200, Stephane Eranian wrote:
> >> +static struct cpu_hw_events *allocate_fake_cpuc(void)
> >> +{
> >> +       struct cpu_hw_events *cpuc;
> >> +       int cpu = smp_processor_id();
> >
> > That's a boo-boo, clearly we are in a preemptible context here (see the
> > GFP_KERNEL allocation on the next line), so using smp_processor_id()
> > isn't valid.
> >
> Good point. I missed that.

Yeah, I did too, Ingo found it during testing.

> > Now since all that allocate_shared_regs() does with it is pick a NUMA
> > node, we should probably use raw_smp_processor_id() and leave it at
> > that, right?
> >
> Yeah, for what we do with fake_cpuc, it does not really matter where
> it comes from. This is not on any critical path. The simplest allocator
> will do it.

OK, fixed that up.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/