Re: [PATCH tip/core/rcu 13/28] nfs,rcu: Convertcall_rcu(nfs_free_delegation_callback) to kfree_rcu()

[Trond Myklebust]

On Wed, 2011-06-08 at 12:29 -0700, Paul E. McKenney wrote: 
> From: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>
> 
> The rcu callback nfs_free_delegation_callback() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(nfs_free_delegation_callback).
> 
> Signed-off-by: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>
> Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> Cc: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
> Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>

Acked-by: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>

> ---
>  fs/nfs/delegation.c |   14 +-------------
>  1 files changed, 1 insertions(+), 13 deletions(-)
> 
> diff --git a/fs/nfs/delegation.c b/fs/nfs/delegation.c
> index bbbc6bf..dd25c2a 100644
> --- a/fs/nfs/delegation.c
> +++ b/fs/nfs/delegation.c
> @@ -21,25 +21,13 @@
>  #include "delegation.h"
>  #include "internal.h"
>  
> -static void nfs_do_free_delegation(struct nfs_delegation *delegation)
> -{
> -	kfree(delegation);
> -}
> -
> -static void nfs_free_delegation_callback(struct rcu_head *head)
> -{
> -	struct nfs_delegation *delegation = container_of(head, struct nfs_delegation, rcu);
> -
> -	nfs_do_free_delegation(delegation);
> -}
> -
>  static void nfs_free_delegation(struct nfs_delegation *delegation)
>  {
>  	if (delegation->cred) {
>  		put_rpccred(delegation->cred);
>  		delegation->cred = NULL;
>  	}
> -	call_rcu(&delegation->rcu, nfs_free_delegation_callback);
> +	kfree_rcu(delegation, rcu);
>  }
>  
>  /**

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/