Re: [PATCH 3/3] printk: Avoid all wakeups from printk

From: Ingo Molnar
Date: Thu Jun 09 2011 - 09:32:50 EST



* Peter Zijlstra <a.p.zijlstra@xxxxxxxxx> wrote:

> +void console_unlock(void)
> +{
> + if (console_suspended) {
> + up(&console_sem);
> + return;
> + }
> +
> + __console_flush();
> +
> + up(&console_sem);
> +}

Hm, this seems to be a very roundabout way of doing:

void console_unlock(void)
{
if (!console_suspended)
__console_flush();

up(&console_sem);
}

Right?

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/