Re: [PATCH 1/4] watchdog: fix rounding issues in get_sample_period()

From: Don Zickus
Date: Thu Jun 09 2011 - 07:48:10 EST


On Thu, May 19, 2011 at 09:26:31AM -0700, Mandeep Singh Baines wrote:
> Don Zickus (dzickus@xxxxxxxxxx) wrote:
> > On Mon, May 16, 2011 at 04:34:58PM -0700, Mandeep Singh Baines wrote:
> > > In get_sample_period(), softlockup_thresh is integer divided by 5 before
> > > the multiplication by NSEC_PER_SEC. This results in softlockup_thresh
> > > being rounded down to the nearest integer multiple of 5.
> > >
> > > For example, a softlockup_thresh of 4 rounds down to 0.
> >
> > Mandeep,
> >
> > Thanks for the patches. Unfortunately, I am taking some time off so I'll
> > shephard these patches when I get back. For the most part they look fine,
> > aside from Ingo's comments.
> >
>
> No problem. Enjoy your time off:)
>
> Ingo, since Don is out, would you mind acking the patches (assuming you're
> happy). It simplifies pushing these patches into our local ChromiumOS tree
> if I have an upstream ack.

Hi Mandeep,

It looks like Ingo took most of your patches. Is there any outstanding
ones that didn't make it that you see?

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/