Re: [PATCH 10/14] netvm: Set PF_MEMALLOC as appropriate during SKB processing

[Michał Mirosław]

2011/6/9 Mel Gorman <mgorman@xxxxxxx>:
[...]
> +/*
> + * Limit which protocols can use the PFMEMALLOC reserves to those that are
> + * expected to be used for communication with swap.
> + */
> +static bool skb_pfmemalloc_protocol(struct sk_buff *skb)
> +{
> +       switch (skb->protocol) {
> +       case __constant_htons(ETH_P_ARP):
> +       case __constant_htons(ETH_P_IP):
> +       case __constant_htons(ETH_P_IPV6):
> +       case __constant_htons(ETH_P_8021Q):
> +               return true;
> +       default:
> +               return false;
> +       }
> +}

This is not needed and wrong. Whatever list there will be, it's going
to always miss some obscure setup (or not that obscure, like
ATAoverEthernet).

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/