Re: [PATCH/RESEND v15 1/10] usb: Add usb_endpoint_descriptor to bepart of the struct usb_ep

[Felipe Balbi]

Hi,

On Mon, Jun 06, 2011 at 02:40:45PM +0300, Tatyana Brokhman wrote:
> Change usb_ep_enable() prototype to use endpoint descriptor from usb_ep.
> This optimization spares the FDs from saving the endpoint chosen
> descriptor. This optimization is not full though. To fully exploit this
> change one needs to update all the UDCs as well since in the current
> implementation each of them saves the endpoint descriptor in it's
> internal (and extended) endpoint structure.
> 
> Signed-off-by: Tatyana Brokhman <tlinder@xxxxxxxxxxxxxx>

now that I look at this patch carefully, won't this break all gadget
drivers ? I mean, if I apply this patch, all gadget drivers will be
using descriptor from struct usb_ep, but noone is actually assigning
that pointer.

A better approach would be to:

(a) add the field to struct usb_ep
(b) make each controller assign that pointer while still keeping the
	last one (keep the old interface too, make one patch per
	controller)
(c) make each gadget/function driver use the new interface (one patch
	per driver)
(d) remove the old interface from all controller (one patch for all of
	them)

-- 
balbi

Attachment: signature.asc
Description: Digital signature