Re: [PATCH RESEND]Remove a warning for drivers/edac/i82975x_edac.c

From: Connor Hansen
Date: Thu Jun 09 2011 - 00:27:16 EST


When I compile 3.0.0-rc2+ I don't get this warning.
please make sure this issue still exists.

Connor

On Wed, Jun 8, 2011 at 8:04 PM, Harry Wei <jiaweiwei.xiyou@xxxxxxxxx> wrote:
> From: Harry Wei <harryxiyou@xxxxxxxxx>
>
> When i compile 2.6.39.1, a warning shows like below.
> This patch can fix the warning. And i works well with
> my PC.
>
> [...]
> CC [M] Âdrivers/edac/e752x_edac.o
> CC [M] Âdrivers/edac/i82875p_edac.o
> CC [M] Âdrivers/edac/i82975x_edac.o
> drivers/edac/i82975x_edac.c: In function ïïïi82975x_process_error_infoïïï:
> drivers/edac/i82975x_edac.c:298: warning: integer constant is too large for ïïïunsigned longïïï type
> CC [M] Âdrivers/edac/i3000_edac.o
> CC [M] Âdrivers/edac/i3200_edac.o
> CC [M] Âdrivers/edac/x38_edac.o
> CC [M] Âdrivers/edac/i82860_edac.o
> [...]
>
>
> Signed-off-by: Harry Wei <harryxiyou@xxxxxxxxx>
> Index: prj/drivers/edac/i82975x_edac.c
> ===================================================================
> --- prj.orig/drivers/edac/i82975x_edac.c    Â2011-06-04 10:09:55.351174516 +0800
> +++ prj/drivers/edac/i82975x_edac.c   2011-06-04 10:10:30.875168437 +0800
> @@ -293,9 +293,9 @@
> Â Â Â Â Â Â Â Âinfo->errsts = info->errsts2;
> Â Â Â Â}
>
> - Â Â Â page = (unsigned long) info->eap;
> + Â Â Â page = (unsigned long long) info->eap;
> Â Â Â Âif (info->xeap & 1)
> - Â Â Â Â Â Â Â page |= 0x100000000ul;
> + Â Â Â Â Â Â Â page |= 0x100000000ull;
> Â Â Â Âchan = page & 1;
> Â Â Â Âpage >>= 1;
> Â Â Â Âoffst = page & ((1 << PAGE_SHIFT) - 1);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
> Please read the FAQ at Âhttp://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/