Re: [PATCH tip/core/rcu 03/28] rcu: Streamline code produced by__rcu_read_unlock()

[Josh Triplett]

On Wed, Jun 08, 2011 at 12:29:42PM -0700, Paul E. McKenney wrote:
> Given some common flag combinations, particularly -Os, gcc will inline
> rcu_read_unlock_special() despite its being in an unlikely() clause.
> Use noline to prohibit this misoptimization.

If rcu_read_unlock_special only gets called in the one place, why does
it hurt to inline it, as long as the inlined code stays on the cold
path?  Might as well remove the overhead of the function call.

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/