Re: [PATCH] checkpatch: Validate signature styles and To: and Cc:lines

[Joe Perches]

On Wed, 2011-06-08 at 16:24 -0400, Nick Bowler wrote:
> On 2011-06-08 12:34 -0700, Joe Perches wrote:
> > Signatures have many forms and can sometimes cause problems
> > if not in the correct format when using git send-email or quilt.
> > Try to verify the signature tags and email addresses to use
> > the generally accepted "Signed-off-by: Full Name <email@xxxxxxxxxx>"
> > form.
> [...]
> > +			my $suggested_email = format_email(parse_email($email));
> > +			if ($suggested_email eq "") {
> > +				ERROR("email address '$email' is unrecognizable\n" . $herecurr);
> > +			} elsif ($suggested_email ne $email) {
> > +				WARN("email address '$email' might be better as '$suggested_email'\n" . $herecurr);
> If you're going to make suggestions, you should at the very least ensure
> that the suggestions are actually valid email addresses.  Otherwise,
> this script will suggest replacing valid addresses with invalid ones!

Anyone that puts angle brackets in a quoted name
is pretty silly.  There aren't any in git history.

What I did is pretty simple and covers most all
normally used cases.

You are free to improve email parsing.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/