Re: [SCSI] tcm_fc: Adding FC_FC4 provider (tcm_fc) for FCoE target(TCM - target core) support

[Geert Uytterhoeven]

> Â Â[SCSI] tcm_fc: Adding FC_FC4 provider (tcm_fc) for FCoE target (TCM - target core) support
>
> Â ÂThis is a comprehensive patch for FC-FC4 provider. tcm_fc is a FC-FC4
> Â Âprovider which glues target core (TCM) with Fiber channel library
> Â Â(libfc). tcm_fc uses existing FC4 provider hooks from Fiber channel
> Â Âlibrary. This Fiber channel library is used by FCoE (transport - FC
> Â Âover Ethernet) protocol driver as well.

> --- /dev/null
> +++ b/drivers/target/tcm_fc/tfc_conf.c

> +static int __init ft_init(void)
> +{
> + Â Â Â if (ft_register_configfs())
> + Â Â Â Â Â Â Â return -1;
> + Â Â Â if (fc_fc4_register_provider(FC_TYPE_FCP, &ft_prov)) {
> + Â Â Â Â Â Â Â ft_deregister_configfs();
> + Â Â Â Â Â Â Â return -1;
> + Â Â Â }
> + Â Â Â blocking_notifier_chain_register(&fc_lport_notifier_head, &ft_notifier);
> + Â Â Â fc_lport_iterate(ft_lport_add, NULL);
> + Â Â Â return 0;
> +}
> +
> +static void __exit ft_exit(void)
> +{
> + Â Â Â blocking_notifier_chain_unregister(&fc_lport_notifier_head,
> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â&ft_notifier);
> + Â Â Â fc_fc4_deregister_provider(FC_TYPE_FCP, &ft_prov);
> + Â Â Â fc_lport_iterate(ft_lport_del, NULL);
> + Â Â Â ft_deregister_configfs();
> + Â Â Â synchronize_rcu();
> +}
> +
> +#ifdef MODULE
> +MODULE_DESCRIPTION("FC TCM fabric driver " FT_VERSION);
> +MODULE_LICENSE("GPL");
> +module_init(ft_init);
> +module_exit(ft_exit);
> +#endif /* MODULE */

If CONFIG_TCM_FC=y, this gives:

| drivers/target/tcm_fc/tfc_conf.c:642: warning: âft_initâ defined but not used

Shouldn't the #ifdef MODULE and #endif just be removed?

Who else initializes this module if it's builtin?
E.g. ft_register_configfs() is global, but not used outside this source file?

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/