Re: [PATCH 1/1] [virt] virtio-blk: Use ida to allocate disk index

[Mark Wu]

On 06/02/2011 06:34 AM, Michael S. Tsirkin wrote:
> On Wed, Jun 01, 2011 at 04:25:48AM -0400, Mark Wu wrote:
>> On 06/01/2011 03:24 AM, Mark Wu wrote:
>>> -	if (index_to_minor(index)>= 1<<  MINORBITS)
>>> -		return -ENOSPC;
>>> +	do {
>>> +		if (!ida_pre_get(&vd_index_ida, GFP_KERNEL))
>>> +			return err;
>>> +
>> There's a problem in above code: err is not initialized before
>> using, so change it to return -1;
>> +       do {
>> +               if (!ida_pre_get(&vd_index_ida, GFP_KERNEL))
>> +                       return -1;
> 
> Not -1. Pls return -ENOMEM.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Hi Michael,
Thanks for pointing out that. This is the revised patch.